-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "tip" version #531
base: master
Are you sure you want to change the base?
Add "tip" version #531
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,8 +111,6 @@ for version; do | |
|
||
fullVersion="$(jq -r '.[env.version].version' versions.json)" | ||
|
||
[[ "$fullVersion" == *.*[^0-9]* ]] || fullVersion+='.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is technically valid even without this PR, but it's currently harmless (however with it in this PR, we end up with tags like |
||
|
||
if [ "$version" = "$fullVersion" ]; then | ||
baseAliases=( "${versionAliases[@]}" ) | ||
else | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of this "fun" with Go 1.23 + QEMU, I haven't done much testing of this on architectures other than amd64 and i386, so that's a notable blind spot that's probably worth more testing before we consider merging