Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit "external-pins" #13567

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Nov 19, 2022

The goal of this directory is two-fold: to list the explicitly allowable external dependencies and to pin those external dependencies to a specific content-addressable digest such that we can update them in the same way we do everything else (and then trigger rebuilds properly based on them, too).

Closes #9445

(This is possible thanks to the tooling updates in docker-library/bashbrew#55 and docker-library/bashbrew#56 🤘)

The goal of this directory is two-fold: to list the explicitly allowable external dependencies and to pin those external dependencies to a specific content-addressable digest such that we can update them in the same way we do everything else (and then trigger rebuilds properly based on them, too).
@yosifkit yosifkit merged commit 0342322 into docker-library:master Nov 29, 2022
@yosifkit yosifkit deleted the external-pins branch November 29, 2022 01:29
@fatherlinux
Copy link

@yosifkit I think the docs still need updated? It only shows scratch, windows core, and windows server as the exceptions

@tianon
Copy link
Member Author

tianon commented Nov 29, 2022

Yeah, the docs do still need to be updated, but we also need to revert this and take a different filenaming approach thanks to Windows (which I tested, but not via git clone, only via touch that comes with Git Bash and I wrongly assumed that Git itself would follow the same rules and make the same smart conversions that the MSYS touch did 🤦).

#13608 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the Red Hat Universal Base Image as an official image
3 participants