add dotted environment variables test #15668
Conversation
test/tests/run-java-in-container.sh
Outdated
| if [ $testDir == *"dotted-environment-variables"* ]; then | ||
| docker run --rm -e "variable.with.a.dot=a.dotted.value" "$newImage" java -cp . container | ||
| else | ||
| docker run --rm "$newImage" java -cp . container | ||
| fi |
There was a problem hiding this comment.
This one-test-specific conditional feels a bit icky in an otherwise generic script 😞
Our test framework wasn't really built with this kind of thing in mind, and it's really showing its age 😭
There was a problem hiding this comment.
Does pattern matching work when == is used with [ ]? I've always read the bash(1) man page as saying that that pattern matching was employed with [[ ]].
[[ expression ]]
…
When the == and != operators are used, the string to the right of the operator is considered a pattern and matched according to the rules described below under Pattern Matching, as if the extglob shell option were enabled.
Rereading, the comma makes it a bit ambiguous as to whether it is saying the == enables Pattern Matching at all or Pattern Matching with extglob enabled.
There was a problem hiding this comment.
Seems like the double square brackets are needed:
$ bash --version
GNU bash, version 5.2.15(1)-release (aarch64-apple-darwin22.1.0)
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ bash -c 'testDir=a-dotted-environment-variables-dir; if [ $testDir == *"dotted-environment-variables"* ]; then echo true; else echo false; fi;'
false
$ bash -c 'testDir=a-dotted-environment-variables-dir; if [[ $testDir == *"dotted-environment-variables"* ]]; then echo true; else echo false; fi;'
trueThere was a problem hiding this comment.
This one-test-specific conditional feels a bit icky in an otherwise generic script 😞
Our test framework wasn't really built with this kind of thing in mind, and it's really showing its age 😭
This feedback is still unresolved -- I'm not sure what to suggest, however.
This should help us catch bugs like adoptium/containers#415 in the future.
This could be made an OpenJDK-specific test but I figured there is likely no harm running it for all images