-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.7/alpine3.8 #303
Add Python 3.7/alpine3.8 #303
Conversation
The Alpine 3.8 image has been available. Updated |
You'll need #304 and to update diff --git a/update.sh b/update.sh
index 11683d6..7f53640 100755
--- a/update.sh
+++ b/update.sh
@@ -112,7 +112,7 @@ for version in "${versions[@]}"; do
echo "$version: $fullVersion"
for v in \
- alpine{3.6,3.7} \
+ alpine{3.6,3.7,3.8} \
{wheezy,jessie,stretch}{/slim,/onbuild,} \
windows/nanoserver-{1709,sac2016} \
windows/windowsservercore-{1709,ltsc2016} \
@@ -154,8 +154,8 @@ for version in "${versions[@]}"; do
esac
# https://bugs.python.org/issue32598 (Python 3.7.0b1+)
- # TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL doesn't implement (yet?)
- if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine* ]]; then
+ # TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL 2.6 in Alpine 3.7 doesn't implement
+ if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine3.7 ]]; then
sed -ri -e 's/libressl/openssl/g' "$dir/Dockerfile"
fi
A Python 2.7/Alpine 3.8 image would be cool too 🙋🏼♂️ |
@JayH5 Thanks. I have updated it. |
# TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL doesn't implement (yet?) | ||
if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine* ]]; then | ||
# TL;DR: Python 3.7+ uses OpenSSL functionality which LibreSSL 2.6.x in Alpine 3.7 doesn't implement | ||
if [[ "$version" == 3.7* ]] && [[ "$variant" == alpine3.7 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be alpine3.8
instead of alpine3.7
, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lorddaedra It isn't. On alpine3.8
we can use libressl
, the package's version is 2.7.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like, you are right...
then we should merge this PR...
do we have any reasons to wait for anything?..
Can we have also python 3.6 with alpine 3.8 ? |
@pvizeli Yes, we can. |
#311 👍
|
Add Alpine 3.8 and change openssl to libressl. Because Alpine 3.8 updated libressl to 2.7.4-r0 which Python 3.7's
ssl
module can compatible with it.Now the official Alpine 3.8 is not not available. gliderlabs/docker-alpine#418
So I build one Alpine 3.8 image locally and test this change.
After the Alpine 3.8 image be available, I will change
.travis.yml
Fixes #300