This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 177
Add warnings for env_file entries not copied #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssessouza
force-pushed
the
add-env_file-warning
branch
2 times, most recently
from
September 10, 2019 17:37
b2c349c
to
ce98e6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 70.57% 70.53% -0.04%
==========================================
Files 62 62
Lines 3208 3248 +40
==========================================
+ Hits 2264 2291 +27
- Misses 639 647 +8
- Partials 305 310 +5
Continue to review full report at Codecov.
|
ulyssessouza
force-pushed
the
add-env_file-warning
branch
from
September 10, 2019 18:37
ce98e6f
to
8b13bfc
Compare
ndeloof
suggested changes
Sep 11, 2019
ulyssessouza
force-pushed
the
add-env_file-warning
branch
2 times, most recently
from
September 11, 2019 11:45
978c7e5
to
538f3be
Compare
ndeloof
approved these changes
Sep 11, 2019
ulyssessouza
force-pushed
the
add-env_file-warning
branch
3 times, most recently
from
September 11, 2019 14:50
29a4e9c
to
67bd40e
Compare
ulyssessouza
force-pushed
the
add-env_file-warning
branch
4 times, most recently
from
September 13, 2019 10:00
14cf5aa
to
70a508f
Compare
ulyssessouza
force-pushed
the
add-env_file-warning
branch
2 times, most recently
from
October 8, 2019 09:46
728293d
to
7617c51
Compare
ulyssessouza
force-pushed
the
add-env_file-warning
branch
from
November 5, 2019 12:43
7617c51
to
b86ac6c
Compare
Please sign your commits following these rules: $ git clone -b "add-env_file-warning" [email protected]:ulyssessouza/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354452128
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
ulyssessouza
force-pushed
the
add-env_file-warning
branch
from
November 5, 2019 15:03
10bb0bd
to
ab849c6
Compare
ulyssessouza
force-pushed
the
add-env_file-warning
branch
2 times, most recently
from
November 6, 2019 11:58
067db51
to
2797be4
Compare
silvin-lubecki
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small typo fixed
ulyssessouza
force-pushed
the
add-env_file-warning
branch
4 times, most recently
from
November 8, 2019 06:22
db4eaaf
to
d71c87b
Compare
As 'env_file' entries are not taken in account, we warn the user to copy that and fix it's compose file. Signed-off-by: Ulysses Souza <[email protected]>
ulyssessouza
force-pushed
the
add-env_file-warning
branch
from
November 8, 2019 09:12
d71c87b
to
d2c567b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As 'env_file' entries are not taken in account,
we warn the user to copy that and fix it's
compose file.
- What I did
Add a warning for each
env_file
entry on each service- How I did it
By checking the env_file block for each service entry in
docker app init
- How to verify it
Create a
docker-compose.yml
file with:Run:
- Description for the changelog
Add warnings for
env_file
entries not copied- A picture of a cute animal (not mandatory but encouraged)