This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Adjust the "docker app build" UX #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
build_more
branch
2 times, most recently
from
e8c8507
to
73ef1b1
Compare
docker app build -f <path to x.dockerapp folder> <path to docker context, typically "."> Signed-off-by: Nicolas De Loof <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=========================================
- Coverage 72.51% 72.41% -0.1%
=========================================
Files 56 56
Lines 3002 3031 +29
=========================================
+ Hits 2177 2195 +18
- Misses 552 559 +7
- Partials 273 277 +4
Continue to review full report at Codecov.
|
rumpl
reviewed
Oct 16, 2019
ndeloof
force-pushed
the
build_more
branch
3 times, most recently
from
412597b
to
69b6f07
Compare
rumpl
reviewed
Oct 17, 2019
rumpl
reviewed
Oct 17, 2019
use docker-compose `Image` attribute if set
use {tag}-{service} if user has specified a tag with --tag
never tag the invocation image
Signed-off-by: Nicolas De Loof <[email protected]>
silvin-lubecki
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Took it for a spin and that's definitely super cool, thanks @ndeloof and sorry for the back and forth 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Amended the
docker app builduser experience:tag is optional (set by --tag option)
a context path is required (aligned with docker build)
- How I did it
service image get tagged, based on metadata or
--tagoption- How to verify it
docker app build --t foo:1 .will tag built services images asfoo:1-serviceand invocation image asfoo-1-installer- Description for the changelog
Service images get tagged during build to match --tag option or metadata
- A picture of a cute animal (not mandatory but encouraged)
