This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
APP-304 Update e2e tests using --folder flag #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "app-304_correct_app_build_help" [email protected]:aiordache/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
eunomie
approved these changes
Nov 6, 2019
Signed-off-by: Anca Iordache [email protected]
aiordache
force-pushed
the
app-304_correct_app_build_help
branch
from
5749a42
to
7af854e
Compare
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
=========================================
Coverage ? 71.43%
=========================================
Files ? 59
Lines ? 3175
Branches ? 0
=========================================
Hits ? 2268
Misses ? 601
Partials ? 306Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updated the e2e tests that were using the --folder flag
- How to verify it
The e2e
TestRender/envvariablestest should pass now.- A picture of a cute animal (not mandatory)
Signed-off-by: Anca Iordache [email protected]