Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Experimental flags are hidden by experimentalCLI #736

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Nov 12, 2019

The code had the (wrong) annotation "experimental"

The code had the (wrong) annotation "experimental"

Signed-off-by: Djordje Lukic <[email protected]>
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #736 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   69.03%   69.03%   -0.01%     
==========================================
  Files          64       63       -1     
  Lines        3443     3401      -42     
==========================================
- Hits         2377     2348      -29     
+ Misses        748      742       -6     
+ Partials      318      311       -7
Impacted Files Coverage Δ
internal/commands/run.go 61.95% <100%> (ø) ⬆️
types/parameters/parameters.go 92.06% <0%> (-4.77%) ⬇️
internal/packager/custom.go
internal/commands/image/list.go 83.67% <0%> (+0.81%) ⬆️
internal/packager/cnab.go 97.94% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04214e3...d83eb35. Read the comment docs.

@rumpl rumpl marked this pull request as ready for review November 12, 2019 15:28
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 80c0233 into docker:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants