Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert "set repository and ghtoken attributes for gha cache type" #1183

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

crazy-max
Copy link
Member

relates to #1181

#1133 introduces a change setting automatically repository and ghtoken attributes for gha cache export type to be able to use the GitHub API for checking cache keys and avoid GitHub Actions cache API throttling but we got reports in #1181 showing a regression when writing blobs: #1181 (comment)

While this is being investigating, let's revert this change.

@dvdksn Would need a follow-up in https://docs.docker.com/build/cache/backends/gha/#avoid-github-actions-cache-api-throttling to remove the part saying we set it automatically 🙏.

@crazy-max crazy-max merged commit 1ca370b into docker:master Jul 17, 2024
59 checks passed
@crazy-max crazy-max deleted the revert-gha-cache-to branch July 17, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant