build(deps): bump github.com/anchore/syft from 0.89.0 to 0.94.0 #79
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/anchore/syft](https://github.com/anchore/syft) from 0.89.0 to 0.94.0. - [Release notes](https://github.com/anchore/syft/releases) - [Changelog](https://github.com/anchore/syft/blob/main/.goreleaser.yaml) - [Commits](anchore/syft@v0.89.0...v0.94.0) --- updated-dependencies: - dependency-name: github.com/anchore/syft dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
@cdupuis @crazy-max, sorry this has not been top priority for me recently 😢 Do you think we could do a release based on this syft version (assuming tests pass neatly, etc). |
jedevc
force-pushed
the
dependabot/go_modules/github.com/anchore/syft-0.94.0
branch
2 times, most recently
from
4386060
to
40ca704
Compare
go.mod
Outdated
| @@ -1,30 +1,35 @@ | |||
| module github.com/docker/buildkit-syft-scanner | |||
|
|
|||
| go 1.20 | |||
| go 1.21.0 | |||
There was a problem hiding this comment.
I don't think that's correct and should be <major>.<minor> no?
| go 1.21.0 | |
| go 1.21 |
There was a problem hiding this comment.
🤔 odd. I set it to go 1.21, and go mod tidy produced this...
There was a problem hiding this comment.
I was looking at the docs and this might be correct since Go 1.21: https://go.dev/doc/modules/gomod-ref#go-notes
At go 1.21 or higher:
- The go line declares a required minimum version of Go to use with this module.
- The go line must be greater than or equal to the go line of all dependencies.
- The go command no longer attempts to maintain compatibility with the previous older version of Go.
- The go command is more careful about keeping checksums of go.mod files in the go.sum file.
go.mod
Outdated
| go 1.20 | ||
| go 1.21.0 | ||
|
|
||
| toolchain go1.21.3 |
There was a problem hiding this comment.
I guess since we enforce Go toolchain's to 1.21.3 here it would downgrade to this version if GO_VERSION=1.21 used in the golang image is >1.21.3?
There was a problem hiding this comment.
I think so: https://go.dev/doc/modules/gomod-ref#go-notes (emphasis mine)
Declares a suggested Go toolchain to use with this module. Only takes effect when the module is the main module and the default toolchain is older than the suggested toolchain.
So this was also auto-generated by go mod tidy. I had go 1.21 written in the file, and go 1.21.3 installed locally. go mod tidy tidies this to go 1.21.0 and toolchain go1.21.3. I've bumped to use go 1.21.3 so no toolchain directive is required.
Not quite sure what we want to do across the buildkit-related projects, looks like this is going to be the first of many cases.
There was a problem hiding this comment.
oh so go mod tidy is tidying to this because that's what syft specifies: anchore/syft#2108.
There was a problem hiding this comment.
oh so
go mod tidyis tidying to this because that's what syft specifies: anchore/syft#2108.
Oh boy 🙈
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
dependabot/go_modules/github.com/anchore/syft-0.94.0
branch
from
40ca704
to
c3d37c3
Compare
jedevc
deleted the
dependabot/go_modules/github.com/anchore/syft-0.94.0
branch
Bumps github.com/anchore/syft from 0.89.0 to 0.94.0.
Release notes
Sourced from github.com/anchore/syft's releases.
... (truncated)
Commits
8f6bddeLabel PRs when the json schema changes (#2240)ef43294Add download location when cataloging directory npm package lock (#2238)e1ad340fix: allow packages to be captured from DIST/EGG case (#2239)07f1304Account for maven bundle plugin and fix filename matching (#2220)6c7900fchore(deps): bump actions/checkout from 4.1.0 to 4.1.1 (#2236)7018573Remove internal string set (#2219)f3ad8cfbump clio to get stderr reporting fix (#2232)31f1d7dFix panic for empty input to Swift cataloger (#2226)144ed72Add additional license filenames (#2227)dcec2bcchore(deps): bump github/codeql-action from 2.22.2 to 2.22.3 (#2229)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)