Skip to content

Commit

Permalink
Merge pull request #1129 from crazy-max/fix-docker-context
Browse files Browse the repository at this point in the history
check context builder endpoint
  • Loading branch information
crazy-max authored Jul 29, 2022
2 parents 8288ce9 + e27a596 commit 0078390
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions commands/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,20 @@ func driversForNodeGroup(ctx context.Context, dockerCli command.Cli, ng *store.N
return nil, errors.Errorf("failed to find driver %q", f)
}
} else {
// empty driver means nodegroup was implicitly created as a default
// driver for a docker context and allows falling back to a
// docker-container driver for older daemon that doesn't support
// buildkit (< 18.06).
ep := ng.Nodes[0].Endpoint
dockerapi, err := clientForEndpoint(dockerCli, ep)
if err != nil {
return nil, err
}
// check if endpoint is healthy is needed to determine the driver type.
// if this fails then can't continue with driver selection.
if _, err = dockerapi.Ping(ctx); err != nil {
return nil, err
}
f, err = driver.GetDefaultFactory(ctx, ep, dockerapi, false)
if err != nil {
return nil, err
Expand Down

0 comments on commit 0078390

Please sign in to comment.