Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Make manifest customizable for Kubernetes driver #377

Open
diego-maravankin opened this issue Sep 1, 2020 · 6 comments

Comments

@diego-maravankin
Copy link

Hi guys! First of all, I'd like to thank you for this great tool, it makes it really easy for remote image building in a Kubernetes cluster.

It would be great if buildx allowed the user to customize the manifest used to generate the deployment. My main interests are:

  • resource limits, to avoid the situation where a build might affect other workloads in the kubernetes node. I am aware that this might lead to a build failure.
  • the possibility to add tolerations to the pods, so that I can taint a node to use it exclusively for image building (combinig the toleration with the currently supported nodeSelector configuration) and not affecting other workloads in the kubernetes node.

Thanks guys for this awesome tool!

Diego

@paulbsch
Copy link

It would be especially helpful if there were a kubernetes driver opt for toleration(s) to coincide with the already available nodeselector option.

@zfalen-deloitte
Copy link

+1 for this. Taint / toleration options are key, resource limits would be nice

@crazy-max
Copy link
Member

crazy-max commented Jun 29, 2021

Fixed by #618

@crazy-max crazy-max reopened this Jun 29, 2021
@runcloudone
Copy link

+1 Really this is very important, ti think a lot of people would appreciate it if you add this option

@therapy-lf
Copy link

That's very useful

@ebdekock
Copy link

Would love it if we could get this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants