Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resources handling to kubernetes driver #618

Merged
merged 1 commit into from
May 30, 2021

Conversation

MichalAugustyn
Copy link

This PR covers #210.

I have tried to add a single resources driver-opt at first which could be used as following:

buildx create --driver kubernetes --driver-opt replicas=1,resources="requests.cpu=100m,requests.memory=100Mi,limits.cpu=100m,limits.memory=100Mi"

But then found out its not possible to nest keyvalues inside driver-opts at the moment (raised an issue for that #617)

The next step could be #377 where it was proposed to add a possibility of extending the YAML manifest.

I might take care of that later, but decided to add resource handling in a simple way for now.

@tonistiigi
Copy link
Member

@AkihiroSuda @morlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants