Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote driver guide #1093

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

jedevc
Copy link
Collaborator

@jedevc jedevc commented May 5, 2022

Added basic scenarios for:

  • Connecting over a basic unix socket
  • Connecting to a docker buildkit container
  • Connecting to a kubernetes buildkit deployment

@jedevc
Copy link
Collaborator Author

jedevc commented May 6, 2022

@crazy-max have updated to follow the guide to follow the new-style docs (and tested to make sure they'll look alright on docs.docker.com, once docker/docs#14644 is merged).

@jedevc jedevc force-pushed the remote-driver-guide branch 2 times, most recently from d14eda7 to e57a6b1 Compare May 6, 2022 09:03
@crazy-max crazy-max requested a review from thaJeztah May 6, 2022 09:07
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ptal @tonistiigi @thaJeztah


```console
$ sudo ./buildkitd --group $(id -gn) --addr unix://$HOME/buildkitd.sock
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d rather recommend using rootless mode, but that can be another PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep it simple as it is and add a link to https://github.com/moby/buildkit/blob/master/docs/rootless.md for rootless. Could even leave the default socket path. Can also point to https://github.com/moby/buildkit/tree/master/examples/systemd for running buildkitd with systemd.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have setup those links right below this to point users in the right direction - I think we should keep the specified socket path, otherwise we'll also need to tell users later on to use sudo buildx (since the /var/run/buildkit/ directory is owned by root:root and inaccessible, even with --group, though maybe that's a bug?).


```console
$ sudo ./buildkitd --group $(id -gn) --addr unix://$HOME/buildkitd.sock
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep it simple as it is and add a link to https://github.com/moby/buildkit/blob/master/docs/rootless.md for rootless. Could even leave the default socket path. Can also point to https://github.com/moby/buildkit/tree/master/examples/systemd for running buildkitd with systemd.

docs/guides/remote-builder.md Outdated Show resolved Hide resolved
docs/guides/remote-builder.md Outdated Show resolved Hide resolved
docs/guides/remote-builder.md Outdated Show resolved Hide resolved
@jedevc jedevc requested a review from tonistiigi May 10, 2022 10:10
Signed-off-by: Justin Chadwell <[email protected]>
@tonistiigi tonistiigi merged commit b9a4080 into docker:master May 12, 2022
@crazy-max crazy-max added this to the v0.9.0 milestone Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants