bake: add timestamp function #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform includes a timestamp function to get the current time. go-cty has imported a number of the timestamp functions to it's standard library, however, this was one was not included. This patch simply pulls in the TimestampFunc from Terraform's internal/lang/funcs/datetime.go to allow easily fetching the current time in bake. Signed-off-by: Justin Chadwell <[email protected]>
|
Shouldn't a "timestamp" be a number? |
Strictly speaking I agree, but terraform returns a UTC timestamp string in RFC 3339 format: https://www.terraform.io/language/functions/timestamp |
|
Personally I'd rather keep consistency with how terraform does this (since we also import a bunch of functions from their stdlib). But I do agree, I think as a variable would make more sense (even if it's not a number, but a RFC 3339 string). |
tonistiigi
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1201.
Terraform includes a
timestampfunction to get the current time. go-cty has imported a number of the timestamp functions to it's standard library in zclconf/go-cty#37, however, this was one was not included:The result isn't fully stable, but user's should expect that, and can assign the result to a top-level variable and use that as a consistent timestamp throughout the file.