migrate reference github.com/distribution/reference #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
swap_reference
branch
from
b4117b5
to
2fe7406
Compare
- Parse service device count to int if possible - introduce ResourceResolver to accept remote resources - use include.env_file to resolve variables in included compose.yaml file - remove potential dependencies to disabled services in ForServices - ability to convert a mapping (back) to KEY=VALUE strings - load: include details about included files on Project - include disabled services - local environment to override included .env - load: move env var profile detection to option - add support for multi-document yaml full diff: compose-spec/compose-go@v1.17.0...v1.18.3 Signed-off-by: Sebastiaan van Stijn <[email protected]>
The "reference" package was moved to a separate module, which was extracted from distribution/distribution@b9b1940 Also update compose-go, which also switched to distribution/reference; full diff: compose-spec/compose-go@v1.18.3...v1.18.4 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
swap_reference
branch
from
2fe7406
to
bafdc63
Compare
|
I split this in 2 commits; the first one is updating to the "previous" compose-go, and the second commit only contains the changes related to migrating to the new dependency (which includes a patch-bump of compose-go) |
|
@tonistiigi @crazy-max PTAL 🤗 |
crazy-max
approved these changes
Sep 8, 2023
|
This one good to go, or do we need more reviewers? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "reference" package was moved to a separate module, which was extracted from distribution/distribution@b9b1940