Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: release the file lock before attempting to boot during create #2066

Merged
merged 1 commit into from
Sep 30, 2023
Merged

commands: release the file lock before attempting to boot during create #2066

merged 1 commit into from
Sep 30, 2023

Commits on Sep 29, 2023

  1. commands: release the file lock before attempting to boot during create 

    If the boot command hung or took a long time, it blocked any read
operations (such as `buildx ls`).

When the boot happens, we no longer need to hold the file lock so we can
release it. Releasing multiple times is legal and causes whichever
release that is second to be a no-op so the defer is kept to ensure the
lock is released even when an error condition happens.

Signed-off-by: Jonathan A. Sternberg <[email protected]>
    @jsternberg
    jsternberg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0878d5b View commit details
    Browse the repository at this point in the history