Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/docker/cli-docs-tool to master #2301

Closed
wants to merge 2 commits into from

Conversation

crazy-max
Copy link
Member

Just trying latest changes of cli-docs-tool for man pages generation (docker/cli-docs-tool#14) before creating a release. See last commit for generated files.

cc @dvdksn @thaJeztah

@@ -3,7 +3,7 @@
set -eu -o pipefail

: "${BUILDX_CMD=docker buildx}"
: "${FORMATS=md}"
: "${FORMATS=md,yaml,man}"
Copy link
Contributor

@dvdksn dvdksn Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean we check in all generated formats. Totally fine by me, it alleviates a step in updating the CLI reference downstream (we only need to re-vendor and not manually generate and copy over yaml)

Copy link
Member Author

@crazy-max crazy-max Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for testing if you want to try locally. I don't want to merge this 😇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aw I was getting excited :)

@crazy-max crazy-max closed this Mar 7, 2024
@crazy-max crazy-max deleted the bump-cli-docs-tool branch March 7, 2024 16:28

.SH EXAMPLE
.EX
### Append a new node to an existing builder (--append) {#append}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these first headings in the examples section don't get the .SS markup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants