Allow booting builder after creation #692

crazy-max · 2021-07-25T05:07:08Z

Fixes #189

Allow booting builder after creation with docker buildx create --bootstrap ....

~~Also adds buildx start command.~~

Signed-off-by: CrazyMax [email protected]

tonistiigi · 2021-08-10T20:12:17Z

Not sure if we need a command for this. And as we have buildx stop it should probably be start then. But I think we can start with just a flag.

crazy-max · 2021-08-11T12:27:19Z

And as we have buildx stop it should probably be start then.

👍

But I think we can start with just a flag.

Yeah I thought ~~bootstrap~~ start was a legit command to have here cause of the stop one. Let me know if you don't think so.

Signed-off-by: CrazyMax <[email protected]>

crazy-max · 2021-08-12T06:49:38Z

Remove start command as discussed. PTAL @tonistiigi

crazy-max force-pushed the boostrap-cmd branch from f2013c5 to 649c080 Compare July 25, 2021 05:07

crazy-max marked this pull request as ready for review July 26, 2021 11:21

crazy-max added the kind/enhancement New feature or request label Aug 2, 2021

crazy-max requested a review from tonistiigi August 8, 2021 09:21

crazy-max force-pushed the boostrap-cmd branch from 649c080 to 921f583 Compare August 11, 2021 12:16

Allow booting builder after creation

5d50bd7

Signed-off-by: CrazyMax <[email protected]>

crazy-max force-pushed the boostrap-cmd branch from 921f583 to 5d50bd7 Compare August 12, 2021 06:46

tonistiigi approved these changes Aug 12, 2021

View reviewed changes

tonistiigi merged commit 04bac63 into docker:master Aug 12, 2021

crazy-max deleted the boostrap-cmd branch August 12, 2021 19:24

Provide feedback