Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagetools: fix pushing same image with multiple names #815

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

tonistiigi
Copy link
Member

fixes #799

containerd pusher can’t handle this case atm so we
need to make sure we always create a new resolver
for each name.

This only affects multi-node builds as pushes inside BuildKit use their own resolver pool that protects against this.

Signed-off-by: Tonis Tiigi [email protected]

containerd pusher can’t handle this case atm so we
need to make sure we always create a new resolver
for each name.

Signed-off-by: Tonis Tiigi <[email protected]>
@tonistiigi tonistiigi added this to the v0.7.0 milestone Oct 28, 2021
@tonistiigi tonistiigi merged commit 81cf206 into docker:master Oct 28, 2021
@eliorm32
Copy link

eliorm32 commented Nov 1, 2021

tried using these commands:

docker buildx create --name mybuilder --driver-opt=image=moby/buildkit:master --use
docker buildx create --name mybuilder --append ssh://ubuntu@{arm agent ip} --driver-opt=image=moby/buildkit:master
docker buildx inspect --bootstrap

it didn't seem to work how do i us your changes? i think i'm doing something wrong

@tonistiigi
Copy link
Member Author

@eliorm32 You don't seem to show any error you get. Note that this fix is in buildx tool itself that would need to be updated for testing. Nothing to do with --driver-opt=image=moby/buildkit:master

@eliorm32
Copy link

eliorm32 commented Nov 1, 2021

yes i understand now. this fix was suppose to upload two tags to a docker registry for same build when built on different nodes. i opened the issue. i thought i need to load the driver and it would work now i understand that i need the buildx binaries that include the merge.
i noticed you marked it as a roadmap to 0.7.0 so i guess i will have to wait for 0.7.0 release?

@tonistiigi
Copy link
Member Author

@eliorm32 If you want to test this you can install buildx from the source. https://github.com/docker/buildx#building

@eliorm32
Copy link

eliorm32 commented Nov 1, 2021

Cool will try tomorrow 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple tags using -t --tag not working
3 participants