Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new --orchestrator flag is showing up on too many commands #1099

Closed
dhiltgen opened this issue May 31, 2018 · 0 comments · Fixed by #1106
Closed

The new --orchestrator flag is showing up on too many commands #1099

dhiltgen opened this issue May 31, 2018 · 0 comments · Fixed by #1106

Comments

@dhiltgen
Copy link
Contributor

With the recent refinement of the docker stack command to include kubernetes support, it seems we've wired up the --orchestrator flag too broadly. It is now showing up on top-level commands that it should not.

For example:

% docker container cp --help

Usage:	docker container cp [OPTIONS] CONTAINER:SRC_PATH DEST_PATH|-
	docker cp [OPTIONS] SRC_PATH|- CONTAINER:DEST_PATH

Copy files/folders between a container and the local filesystem

Use '-' as the source to read a tar archive from stdin
and extract it to a directory destination in a container.
Use '-' as the destination to stream a tar archive of a
container source to stdout.

Options:
  -a, --archive               Archive mode (copy all uid/gid information)
  -L, --follow-link           Always follow symbol link in SRC_PATH
      --orchestrator string   Orchestrator to use (swarm|kubernetes|all)

and

% docker volume --help      

Usage:	docker volume COMMAND

Manage volumes

Options:
      --orchestrator string   Orchestrator to use (swarm|kubernetes|all)

Commands:
  create      Create a volume
  inspect     Display detailed information on one or more volumes
  ls          List volumes
  prune       Remove all unused local volumes
  rm          Remove one or more volumes

Run 'docker volume COMMAND --help' for more information on a command.

I believe this flag should only show up on the stack command for now.

silvin-lubecki added a commit to silvin-lubecki/cli that referenced this issue Jun 1, 2018
…mmands, excepting some declared commands, when printing help

Fixes issue docker#1099

Signed-off-by: Silvin Lubecki <[email protected]>
silvin-lubecki added a commit to silvin-lubecki/cli that referenced this issue Jun 1, 2018
…mmands, excepting some specific commands, while printing help

Fixes issue docker#1099

Signed-off-by: Silvin Lubecki <[email protected]>
chris-crone pushed a commit to chris-crone/cli that referenced this issue Jun 11, 2018
…mmands, excepting some specific commands, while printing help

Fixes issue docker#1099

Signed-off-by: Silvin Lubecki <[email protected]>
(cherry picked from commit c003ed1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants