manifest list: request specific permissions

[clnperez]

When creating manifest lists, don't use "*" as the permission when
creating the token handler. This causes problems with gitlab's repos.

Fixes #1010

Signed-off-by: Christy Norman [email protected]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[clnperez]

I hope this is the super simple solution here. I tried another way to do it, but you need push and pull perm for the push, so, it seems like this is easiest/best.

@vdemeester is there a way to download the build artifacts for @jesusofsuburbia to test? I can't find it where I think it should be.

[vdemeester]

@clnperez yeah, it's a bit tricky to get but it's possible to get them from the articfacts in the circleci build (somehow the tab doesn't show when not logged but is accessible) : https://circleci.com/gh/docker/cli/11565#artifacts/containers/0

[clnperez]

@jesusofsuburbia can you try that one out? you can just chmod+x and run it instead of the docker installed on your system. If you expand the build section in the link from the previous comment, you can find binaries for all the platforms docker supports.

[mschrupp]

@clnperez will do so today or tomorrow, thanks so far!

[thaJeztah]

@jlhawn @dmcgowan PTAL

[mschrupp]

@clnperez it works! I tested it multiple times...

docker:18.04.0-ce fails, but overwriting /usr/local/bin/docker with the binary you provided works

thank you so much

[clnperez]

thank you for reporting :)

[thaJeztah]

LGTM, but would like @dmcgowan or @jlhawn to have a quick peek

[dmcgowan]

LGTM

[thaJeztah]

Thanks for reviewing 👍 merging