-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document reserved namespaces deprecation #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some comments on the versions 😅
docs/deprecated.md
Outdated
@@ -19,6 +19,16 @@ The following list of features are deprecated in Engine. | |||
To learn more about Docker Engine's deprecation policy, | |||
see [Feature Deprecation Policy](https://docs.docker.com/engine/#feature-deprecation-policy). | |||
|
|||
### Reserved namespaces in engine labels | |||
|
|||
**Deprecated in Release: v18.05.0** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it was merged after 18.05 was cut, so can you update this to 18.06?
The deprecation policy states we use 3 stable releases (https://docs.docker.com/engine/#installation-guides), so it should become an error in 18.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, so sorry for the delay! Thanks!
org.dockerproject.* in engine labels are now deprecated. Signed-off-by: Ying Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Document that reserved namespaces org.docker., io.docker., and org.dockerproject.* in engine labels are now deprecated.
See moby/moby#36921
cc @thaJeztah