Make an error for an invalid orchestrator #1055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I made an invalid specified orchestrator yield an error instead of being silently ignored.
- How I did it
I added checks and error handling.
- How to verify it
Before if
then (notice the missing r in swarm)
the orchestrator flag value being invalid it falls back to the one defined in
~/.docker/config.json
.Now it correctly fails with
- Description for the changelog
An invalid orchestrator now generates an error instead of being silently ignored.
- A picture of a cute animal (not mandatory but encouraged)