Update Events, Exec, Export, History, Images, Import, Inspect, Load, and Login subcommand fish completions #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
Signed-off-by: Kyle Spiers <[email protected]>
thaJeztah
approved these changes
May 17, 2018
| complete -c docker -A -f -n '__fish_seen_subcommand_from export' -a '(__fish_print_docker_containers all)' -d "Container" | ||
|
|
||
| # history | ||
| complete -c docker -f -n '__fish_docker_no_subcommand' -a history -d 'Show the history of an image' | ||
| complete -c docker -A -f -n '__fish_seen_subcommand_from history' -l format -d 'Pretty-print images using a Go template' |
There was a problem hiding this comment.
Looks like we have some inconsistency in the flag description for --format between commands (Pretty-print images using a Go template vs Format the output using the given Go template.
Perhaps you're interested in doing a follow-up to use a consistent description for all commands?
| @@ -324,6 +335,7 @@ complete -c docker -f -n '__fish_docker_no_subcommand' -a inspect -d 'Return low | |||
| complete -c docker -A -f -n '__fish_seen_subcommand_from inspect' -s f -l format -d 'Format the output using the given go template.' | |||
| complete -c docker -A -f -n '__fish_seen_subcommand_from inspect' -l help -d 'Print usage' | |||
| complete -c docker -A -f -n '__fish_seen_subcommand_from inspect' -s s -l size -d 'Display total file sizes if the type is container.' | |||
| complete -c docker -A -f -n '__fish_seen_subcommand_from inspect' -l type -d 'Return JSON for specified type' | |||
There was a problem hiding this comment.
Also one worth updating in the actual CLI (thinking of something like "Only return objects of the specified type")
|
|
||
| # login | ||
| complete -c docker -f -n '__fish_docker_no_subcommand' -a login -d 'Log in to a Docker registry server' | ||
| complete -c docker -A -f -n '__fish_seen_subcommand_from login' -l help -d 'Print usage' | ||
| complete -c docker -A -f -n '__fish_seen_subcommand_from login' -s p -l password -d 'Password' | ||
| complete -c docker -A -f -n '__fish_seen_subcommand_from login' -l password-stdin -d 'Read password from stdin' | ||
| complete -c docker -A -f -n '__fish_seen_subcommand_from login' -l password-stdin -d 'Take the password from stdin' |
There was a problem hiding this comment.
Heh, I liked the other one better (But I see the CLI uses the new one) 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing #977 and #1005.
This updates the fish completions for Events, Exec, Export, History, Images, Import, Inspect, Load, and Login.