Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use command.Cli interface instead of concrete type… #1124

Conversation

vdemeester
Copy link
Collaborator

… wherever it's possible. Should make it even easier to test and use
another implementation.

Signed-off-by: Vincent Demeester [email protected]

… wherever it's possible. Should make it even easier to test and use
another implementation.

Signed-off-by: Vincent Demeester <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 805b341 into docker:master Jun 14, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.06.0 milestone Jun 14, 2018
@silvin-lubecki silvin-lubecki deleted the using-cli-interface-everywhere-possible branch June 14, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants