-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.03 backport] vendor: Bump gopkg.in/yaml.v2 #2119
[19.03 backport] vendor: Bump gopkg.in/yaml.v2 #2119
Conversation
Signed-off-by: Christopher Crone <[email protected]> (cherry picked from commit 91cf8b0) Signed-off-by: Sebastiaan van Stijn <[email protected]>
ping @silvin-lubecki @chris-crone @vdemeester PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we need this for 19.03.3? |
@@ -315,6 +319,13 @@ func (d *decoder) prepare(n *node, out reflect.Value) (newout reflect.Value, unm | |||
} | |||
|
|||
func (d *decoder) unmarshal(n *node, out reflect.Value) (good bool) { | |||
d.decodeCount++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolyshkin not critical, but it probably won't hurt to have; the beef of the change is in this file (although their fix is a bit weird)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
backport of #2117
To mitigate against malicious YAML (kubernetes/kubernetes#83253), we had implemented our own patch to the yams.v2 library. Now that there's an upstream fix, this PR brings us back to using the upstream library.
Description for the changelog