Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong docker run command #3558

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix wrong docker run command #3558

merged 1 commit into from
Dec 21, 2023

Conversation

gqqnbig
Copy link
Contributor

@gqqnbig gqqnbig commented Apr 14, 2022

It forgot the image name ubuntu.

- How to verify it

docker run -it --rm --gpus '"device=0,2"' nvidia-smi throws error

Unable to find image 'nvidia-smi:latest' locally
docker: Error response from daemon: pull access denied for nvidia-smi, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.

but mine does not.

It forgot the image name ubuntu

Signed-off-by: QQ喵 <[email protected]>
@thaJeztah thaJeztah added this to the 25.0.0 milestone Dec 20, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

did a quick rebase to get CI to run, and will merge once that finishes

@codecov-commenter
Copy link

Codecov Report

Merging #3558 (90a1887) into master (dd3ba73) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3558   +/-   ##
=======================================
  Coverage   59.64%   59.64%           
=======================================
  Files         287      287           
  Lines       24771    24771           
=======================================
  Hits        14774    14774           
  Misses       9111     9111           
  Partials      886      886           

@thaJeztah thaJeztah merged commit 771bc0a into docker:master Dec 21, 2023
76 checks passed
@gqqnbig gqqnbig deleted the patch-1 branch December 21, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants