cmd/docker: areFlagsSupported: don't Ping if not needed #4506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a similar fix as 006c946, which fixed this for detection of commands that were executed. Make sure we don't call the "/_ping" endpoint if we don't need to. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
process/cherry-pick
kind/bugfix
This was referenced Aug 22, 2023
cli/command/system/runInfo: set client API defaults, and negotiated API version when available
#4507
Open
|
@vvoland ptal 🤗 (also opened backports for this one) |
vvoland
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd/docker: areFlagsSupported: don't Ping if not needed
This is a similar fix as 006c946 (#3904), which
fixed this for detection of commands that were executed. Make sure we don't
call the "/_ping" endpoint if we don't need to.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)