-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typos and update formatting #4715
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4715 +/- ##
==========================================
- Coverage 59.68% 59.66% -0.02%
==========================================
Files 287 287
Lines 24865 24760 -105
==========================================
- Hits 14841 14774 -67
+ Misses 9138 9100 -38
Partials 886 886 |
@thaJeztah no I think we are safe - they shouldn't be touching the same files |
Ah, that's great! I saw the kind of changes and though....oh no! If you can help review; that'd be appreciated 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, no big ones, and not all actionable (I plead guilty to thinking out loud)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @thaJeztah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah it needs to be squashed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please squash
In addition to _running_ tasks, the output also shows the task history. For | ||
In addition to running tasks, the output also shows the task history. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the emphasis on "running" here was to prevent it being confused for "The command allows you to run tasks".
This could be "In addition to tasks that are running" or something along those lines, but we can revisit that in a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll do a quick squash
Co-authored-by: David Karlsson <[email protected]> Signed-off-by: Craig Osterhout <[email protected]>
3557b2b
to
5eac07b
Compare
- What I did
Fixed some typos and updated some formatting in the docs.
- How I did it
- How to verify it
- Description for the changelog
Fix typos and update formatting in docs.
- A picture of a cute animal (not mandatory but encouraged)