docs: regenerate markdown

[thaJeztah]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

I think something is broken .. somewhere. Trying to re-generate docs from the master branch (make -f docker.Makefile mdddocs) didn't show me a diff, but I noticed I did get updates when rebasing #4228

[crazy-max]

Wonder if we should always display bool type even if it defaults to false? Would need changes in cli-docs-tool

[thaJeztah]

good one, yes. Looking at the string above, effectively that's the same;

• always show type
• but don't show default if there's no default (or if default == type's empty value??)

(last part doesn't look consistent there though, because --cpu-shares shows 0 as default, which is also the default for an int64 - wondering why that is 🤔

[dvdksn]

we purposefully hide zero values when rendering the pages on docs.docker.com atm
https://github.com/docker/docs/blob/main/layouts/_default/cli.html#L118

[thaJeztah]

Yes, so funny thing is that there's some "special code" for membytes, which describes we did so for Cobra to hide it 🤔

cli/opts/opts.go

Lines 446 to 450 in f6b7a11

	func (m *MemBytes) String() string {
	// NOTE: In spf13/pflag/flag.go, "0" is considered as "zero value" while "0 B" is not.
	// We return "0" in case value is 0 here so that the default value is hidden.
	// (Sometimes "default 0 B" is actually misleading)
	if m.Value() != 0 {

[crazy-max]

Opened docker/cli-docs-tool#50 to display bool type

[thaJeztah]

oh fun! so it does re-generate on master as well, but ... with the old version? Did we forget to update some version somewhere? 🤔

[thaJeztah]

Ah! We did! There's two separate CLI_DOCS_TOOL_VERSION vars, and we only updated one 🤦

cli/scripts/docs/generate-md.sh

Line 5 in f6b7a11

: "${CLI_DOCS_TOOL_VERSION=v0.6.0}"

cli/scripts/docs/generate-yaml.sh

Line 5 in f6b7a11

: "${CLI_DOCS_TOOL_VERSION=v0.7.0}"

[codecov-commenter]

Codecov Report

Merging #4884 (696500e) into master (caf7265) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 696500e differs from pull request most recent head f2e98f9. Consider uploading reports for the commit f2e98f9 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4884   +/-   ##
=======================================
  Coverage   61.32%   61.32%           
=======================================
  Files         287      287           
  Lines       20063    20063           
=======================================
  Hits        12303    12303           
  Misses       6867     6867           
  Partials      893      893           

[dvdksn]

LGTM