#4935 - Fixed broken links to style guide and building documentation #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Punjani <[email protected]>
rpunjani
changed the title
rpunjani
changed the title
Benehiko
reviewed
May 14, 2024
| guide](https://docs.docker.com/opensource/doc-style) and instructions on [building | ||
| the documentation](https://docs.docker.com/opensource/project/test-and-docs/#build-and-test-the-documentation). | ||
| guide](https://docs.docker.com/contribute/style/grammar/) and instructions on [building | ||
| the documentation](https://github.com/docker/docs/blob/main/CONTRIBUTING.md). |
There was a problem hiding this comment.
I think we should avoid links to other github repositories here. I think let's point this to the official docs.
Suggested change
| the documentation](https://github.com/docker/docs/blob/main/CONTRIBUTING.md). | |
| the documentation](https://docs.docker.com/contribute/). |
|
closing this in favor of #5417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4935.
- What I did
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)