-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update prose about image tag/name format #5535
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5535 +/- ##
==========================================
+ Coverage 60.67% 60.92% +0.25%
==========================================
Files 345 345
Lines 23491 23491
==========================================
+ Hits 14252 14313 +61
+ Misses 8266 8205 -61
Partials 973 973 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Thanks 🤗
389dc26
to
a1ca594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually.. Maybe we should use the term image reference
instead of image name
?
Signed-off-by: David Karlsson <[email protected]>
a1ca594
to
2c6b804
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
- What I did
Update the verbiage about the format of image tags/names.
- How I did it
/usr/bin/nvim
- How to verify it
read it
- A picture of a cute animal (not mandatory but encouraged)