-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orchestrator column #973
Orchestrator column #973
Conversation
Seems like you have test failure 😓 |
8b27b4b
to
8108934
Compare
Don't know what you are talking about 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on commit 8108934
8108934
to
762d84c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment for documentation, but otherwise looks good.
I added [WIP]
to the PR title, as this depends on the other PR's being merged first
"Services": stackServicesHeader, | ||
"Name": nameHeader, | ||
"Services": stackServicesHeader, | ||
"Orchestrator": stackOrchestrastorHeader, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you:
- Add the new
Orchestrator
placeholder to the "formatting" section in the docs: https://github.com/docker/cli/blob/master/docs/reference/commandline/stack_ls.md#formatting - Update the
Examples
section to show the new column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed, can you PTAL? Thanks!
762d84c
to
a4e4924
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the other PR's are merged and this is rebased
Signed-off-by: Silvin Lubecki <[email protected]>
a4e4924
to
13d0c9c
Compare
Rebased (and squashed the doc update) ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- What I did
To perform administration tasks more easily, I added an ORCHESTRATOR column in the
docker stack ls
command.- How I did it
I added a column in the Stack formatter, and hardcoded the orchestrator in each list command implementation.
- How to verify it
- Description for the changelog
Added ORCHESTRATOR column to docker stack ls command
- A picture of a cute animal (not mandatory but encouraged)