Address review comments

Signed-off-by: Gabriel Féron <[email protected]>
docker · Dec 15, 2022 · 1cb5536 · 1cb5536
1 parent e4850d9
commit 1cb5536
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/cmd/compose/pull.go b/cmd/compose/pull.go
@@ -68,7 +68,7 @@ func pullCommand(p *projectOptions, backend api.Service) *cobra.Command {
 	return cmd
 }
 
-func FilterServices(project *types.Project, services []string) error {
+func withSelectedServicesOnly(project *types.Project, services []string) error {
 	enabled, err := project.GetServices(services...)
 	if err != nil {
 		return err
@@ -90,7 +90,10 @@ func runPull(ctx context.Context, backend api.Service, opts pullOptions, service
 	}
 
 	if !opts.includeDeps {
-		FilterServices(project, services)
+		err := withSelectedServicesOnly(project, services)
+		if err != nil {
+			return err
+		}
 	}
 
 	return backend.Pull(ctx, project, api.PullOptions{

diff --git a/cmd/compose/push.go b/cmd/compose/push.go
@@ -58,7 +58,10 @@ func runPush(ctx context.Context, backend api.Service, opts pushOptions, service
 	}
 
 	if !opts.IncludeDeps {
-		FilterServices(project, services)
+		err := withSelectedServicesOnly(project, services)
+		if err != nil {
+			return err
+		}
 	}
 
 	return backend.Push(ctx, project, api.PushOptions{