Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to an existing container #159

Closed
marksteve opened this issue Mar 19, 2014 · 16 comments · Fixed by #544
Closed

Link to an existing container #159

marksteve opened this issue Mar 19, 2014 · 16 comments · Fixed by #544

Comments

@marksteve
Copy link

Maybe it could work like this:

links:
  - :existing_container_name
@marksteve marksteve changed the title Links to an existing container Link to an existing container Mar 19, 2014
@ejholmes
Copy link

👍 on this, I'd like to keep several micro services in separate repositories, each with their own fig.yml but share a rabbitmq container. Right now, this doesn't seem possible.

@zazabe
Copy link

zazabe commented Jul 24, 2014

+1 need to share my postgres with several web app, much more easier in dev mode...

@outrunthewolf
Copy link

+1 So is there any workaround for this? I'm keen to get it sorted

@dnephin
Copy link

dnephin commented Aug 18, 2014

I think #318 is along the same lines as this?

I've got what I think is a working prototype, which I hope to work on more this week or next

@aanand
Copy link

aanand commented Aug 21, 2014

In the same way that volumes_from allows both service and container names, maybe links should too, using the same resolution logic.

@koryonik
Copy link

+1 would be useful

@lxbrito
Copy link

lxbrito commented Sep 1, 2014

+1 Need to share postgres, redis etc.

@coco98
Copy link

coco98 commented Sep 26, 2014

+1 Really need this. I like to have separate fig.yml files for different projects, but have some services running in common, so links need to be specified for existing containers.

@tomfotherby
Copy link

+1 I have 3 fig.yml files for 3 projects and one thing common between them all is that they all include a memcache container. It would be fantastic if all projects could share the same memcache container.

@stevenjack
Copy link

👍 On this, I've also got a number of fig.yaml files in separate projects that's I'd like to share a common container.

@jbalonso
Copy link

jbalonso commented Oct 9, 2014

I have implemented this feature request here: https://github.com/LuminosoInsight/fig/tree/external-links. This uses @marksteve's original format proposal, which addresses a different use case than #318, as I am not in a position where it is completely appropriate to assume that all our containers are launched from fig.

I have not submitted a PR yet, as I need to write tests. Also, my approach feels a little uncomfortably brutal (I originally implemented an external_links feature before I found this issue).

@emilisto
Copy link

+1

I run a Consul container for service discovery, which I'd like all my other containers to have access to.

@simonvc
Copy link

simonvc commented Nov 25, 2014

+1 from Starlingbank..

@baptistedonaux
Copy link

+1, it's necessary to deploy

@schmunk42
Copy link

👍

@jbalonso
Copy link

jbalonso commented Dec 4, 2014

#544 should be ready to go to resolve this issue.

xulike666 pushed a commit to xulike666/compose that referenced this issue Jan 19, 2017
…oring

Update vendor.sh to use fix hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.