-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce --timestamp option on compose up #10076
Conversation
798b11e
to
33318e2
Compare
Codecov ReportBase: 76.98% // Head: 75.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10076 +/- ##
==========================================
- Coverage 76.98% 75.79% -1.20%
==========================================
Files 2 2
Lines 252 252
==========================================
- Hits 194 191 -3
- Misses 51 53 +2
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic is good - just the flag name 🙃
df39e57
to
d12a32b
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is exciting! I've waited literally YEARS for this. What version of |
@ndeloof, Thank you. |
But why there is no space after the timestamp? And why it is so long, fractional digits after seconds...
Should ideally be:
|
timestamp format is set by docker engine, compose receives a pre-formatted string which is written on console |
What I did
Add support for
docker compose up --timestamp
to align with same option onlogs
command.Related issue
close #5730
(not mandatory) A picture of a cute animal, if possible in relation to what you did