Updates for 17.07.0-ce-rc1 #18
Conversation
seemethere
force-pushed
the
update_for_170701rc1
branch
from
eb9a696
to
2adcfea
Compare
| curl -fsSl "https://download.docker.com/linux/$lsb_dist/gpg" | $sh_c 'apt-key add -' | ||
| $sh_c "add-apt-repository \"$apt_repo\"" | ||
| curl "https://download.docker.com/linux/$lsb_dist/gpg" | $sh_c 'apt-key add -' | ||
| $sh_c "echo \"$apt_repo\" > /etc/apt/sources.list.d/docker.list" |
There was a problem hiding this comment.
I hope it's not an issue to have it duplicate once in sources.list and once in sources.list.d/docker.list.
There was a problem hiding this comment.
meant as a simple install script for newbie users to quickly install docker on a new system, we don't need to handle all cases of migration process
seemethere
force-pushed
the
update_for_170701rc1
branch
from
f39ff33
to
a2cf293
Compare
|
Please sign your commits following these rules: $ git clone -b "update_for_170701rc1" [email protected]:seemethere/docker-install.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
seemethere
force-pushed
the
update_for_170701rc1
branch
from
a2cf293
to
e88191c
Compare
Major Notes: * Removes old raspbian cruft now that raspbian has a repo on download.docker.com * Adds a support matrix so that we can have an easier time updating what architectures/distros we support * Added support for s390x and aarch64 * Had to change add-apt-repository to an echo into a file, was not functioning correctly on raspbian see moby/moby#31405 * Update testing pipeline for multiarch * Removed deprecation warnings for raspbian Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
update_for_170701rc1
branch
from
e88191c
to
93b1990
Compare
|
This PR removed the mirror support, which is essential for user in China. Is there any plan to bring them back? ping @Hyzhou and @lizzha, have we stopped support for the docker repo mirror in China? BTW, @lizzha, the certificates on https://mirror.azure.cn/ are revoked. |
|
@twang2218 I don't mind adding support for mirrors if we know those mirrors will be maintained |
|
Looks like the mirrors only mirror the old (apt.dockerproject.org / yum.dockerproject.org) repositories, not yet the new download.docker.com repos e.g. https://mirrors.aliyun.com/docker-engine/apt/repo/pool/main/d/docker-engine/ I get a 403 on the azure mirror (but possibly it doesn't have a browsable index) |
|
https://mirrors.aliyun.com/docker-engine This mirror will be maintained by Alibaba Cloud. And it works will now. :) |
|
@Hyzhou Alright I'm fine with that, I'll work up a PR to re-add https://mirrors.aliyun.com/docker-ce |
|
@seemethere The mirror https://mirror.azure.cn/ is supported by Microsoft, could you please also re-add it? @twang2218 the mirror is now only accessible from Azure China Cloud. |
|
@lizzha is the mirror now mirroring download.docker.com or apt.dockerproject.org / yum.dockerproject.org ? |
|
Hi @thaJeztah It's still mirroring apt.dockerproject.org / yum.dockerproject.org, seems like we also need to add download.docker.com. And for compatability, we need to maintain both repos. I will take this as a work item. Thanks. |
|
@lizzha IIRC, Azure mirror was publicly accessible before, right? I remembered that I tested install using Azure mirror after PR moby/moby#27005, and tested after Docker 1.13 release. I didn't realize that you limited the accessibility of Azure docker mirror to Azure China Cloud only since then. I thought the mirror in the docker official install script should be publicly available. About the site certificate revoke issue, I saw it from my Chrome during my attempt of visiting https://mirror.azure.cn today:
Is it because of https://security.googleblog.com/2016/10/distrusting-wosign-and-startcom.html ? |
|
@lizzha it's not good that the mirror is not publicly accessible - there's no way for us to easily verify that the mirror is complete and mirrors the content correctly... |
|
@Hyzhou not a big deal, but do you think you could make the mirror redirect http to https? |
|
@friism if Docker will verify the mirror, is that OK that we open up some IPs for you to access the mirror? |
|
@twang2218 Not sure why you see the certificate issue. It looks good from my side.
|
|
@lizzha certificate which Issued by WoSign was revoked by chrome. |
|
@friism I agree. I will try to do that. make the mirror redirect http to https. |
|
@Hyzhou https://test.docker.com has been updated with the Aliyun mirror Commit hash: cfa611a |
|
@friism Aliyun Mirror used by a lot of service. If we make http redirect https, some service or module which does not support the 3XX redirect probably down. We will transform it gradually. |
|
Aliyun outdated |
|
Can you add other Chinese mirror example USTC https://mirrors.ustc.edu.cn/docker-ce/ |
|
Docker CE has mirror independent. you can find help here. http://mirrors.aliyun.com/help/docker-ce |
|
I already add your QQ ! Can you contact me? |
|
Already solved.Thank you @Hyzhou |
Major Notes:
download.docker.com
what architectures/distros we support
functioning correctly on raspbian see add-apt-repository fails on Raspbian (Jessie) moby/moby#31405
Signed-off-by: Eli Uriegas [email protected]