Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env var name in release pipeline #3263

Merged
merged 1 commit into from
May 23, 2024

Conversation

krissetto
Copy link
Contributor

Fixed the env var name passed into the Generate Package job of the release pipeline to match what is used in the Makefile

Signed-off-by: Christopher Petito <[email protected]>
@krissetto krissetto self-assigned this May 23, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurazard laurazard merged commit b33088e into docker:main May 23, 2024
11 checks passed
@krissetto
Copy link
Contributor Author

For the sake of whoever might come here in the future, this PR was unnecessary because we actually needed the env var name to match what hatch was expecting, since the packaging job of the release pipeline doesn't use our Makefile.

Proper fix was done here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants