-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose-file: document additional changes in the 3.8 schema #10980
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
d43f468
to
2c54c9f
Compare
@@ -808,10 +812,15 @@ services: | |||
- spread: node.labels.zone | |||
``` | |||
|
|||
#### replicas | |||
#### max_replicas_per_node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I swapped the order with replicas
, because max_replicas_per_node
is under placement
(so not at the same level as replicas
Deploy preview for docsdocker ready! Built with commit d43f468 |
Deploy preview for docsdocker ready! Built with commit 2c54c9f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @thaJeztah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @thaJeztah
relates to docker/cli#896, docker/cli#1100, docker/cli#1746, docker/cli#1783, docker/cli#1410