Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose-file: document additional changes in the 3.8 schema #10980

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Jun 10, 2020
@@ -808,10 +812,15 @@ services:
- spread: node.labels.zone
```

#### replicas
#### max_replicas_per_node
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swapped the order with replicas, because max_replicas_per_node is under placement (so not at the same level as replicas

@netlify
Copy link

netlify bot commented Jun 10, 2020

Deploy preview for docsdocker ready!

Built with commit d43f468

https://deploy-preview-10980--docsdocker.netlify.app

@thaJeztah
Copy link
Member Author

@usha-mandya @ulyssessouza ptal

@netlify
Copy link

netlify bot commented Jun 10, 2020

Deploy preview for docsdocker ready!

Built with commit 2c54c9f

https://deploy-preview-10980--docsdocker.netlify.app

Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @thaJeztah.

Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thaJeztah

@usha-mandya usha-mandya merged commit 36e4831 into docker:master Jun 12, 2020
@thaJeztah thaJeztah deleted the compose_3.8_additions branch June 12, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants