-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for upcoming Docker Desktop 3.3.2 release #12775
Conversation
Signed-off-by: David Scott <[email protected]>
Deploy preview for docsdocker ready! Built with commit 582f237 |
docker-for-mac/release-notes.md
Outdated
- Fixed a bug where a `metrics-port` defined in the engine's `daemon.json` blocks application restart. | ||
- Fixed a leak dynamic ports ("ephemeral ports") e.g. `docker run -p 80`. Fixes [docker/for-mac#5611](https://github.com/docker/for-mac/issues/5611). | ||
- Emulate a more modern Intel CPU with `qemu` on an Apple chip, for better image compatibility. See [docker/for-mac#5561](https://github.com/docker/for-mac/issues/5561). | ||
- Removed the "Deploy Docker Stacks to Kubernetes by default" Kubernetes setting. Fixes [docker/for-mac#4966](https://github.com/docker/for-mac/issues/4966). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to say more about this. It might not be clear why we removed an option and what people are supposed to do instead.
Did we relnote when we removed compose on kube? -- if so we could point to it. We should say that the option has been removed because c-o-k is no longer bundled but is still available for download separately. (If that's accurate).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 2.4.0.0 we said:
- Compose-on-Kubernetes is no longer included in the Docker Desktop installer. You can download it separately from the compose-on-kubernetes release page.
The repo docker/compose-on-kubernetes
has since been archived and is read-only.
Looking at the referenced bug report the situation is unclear:
I have the same problem and now https://github.com/docker/compose-on-kubernetes is archived and no longer mantained.
This is not well documented at all. From the documentation one would think that this would work out of the box
There is an open PR to remove a reference to it from the docs: #12737
I'm not sure what to recommend to users. I'll do a bit more digging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a patch to recommend using https://kompose.io which has the closest workflow i.e.
- develop with
docker compose
locally as normal - run
kompose convert
to generate some yaml kubectl apply
to deploy to a cluster
I also moved this line to the top of the list. Maybe we should have a section for "Removed Features"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agree. We can add a new section below bug fixes called 'Removed features' and add this note there for visibility. We can do similar in upcoming releases for deprecated features too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the "Removed features" section and moved the note into it. I removed the specific recommendation for kompose for now as I haven't tried it personally and am not 100% sure whether it's a suitable recommendation or not.
- Enable buildkit garbage collection by default. | ||
- Fixed a bug which blocked `docker run -p 123`. Fixes [docker/for-mac#5589](https://github.com/docker/for-mac/issues/5589). | ||
- Disable the HTTP and HTTPS transparent proxies when there is no upstream proxy set. Fixes [docker/for-mac#5572](https://github.com/docker/for-mac/issues/5572). | ||
- Revert to the HTTP and HTTPS proxy implementation used in 3.2.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a list of bugs this will fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I don't know for sure which ones. If release wasn't imminent I would share a master
build with users on tickets but since we're about to release I think it would be easier / less spammy to add the tickets to the release notes afterwards in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Co-authored-by: Stephen Turner <[email protected]>
Co-authored-by: Stephen Turner <[email protected]>
Signed-off-by: David Scott <[email protected]>
Signed-off-by: David Scott <[email protected]>
Co-authored-by: Stefan Scherer <[email protected]>
Co-authored-by: Stefan Scherer <[email protected]>
Signed-off-by: David Scott <[email protected]>
- [Docker Compose 1.29.1](https://github.com/docker/compose/releases/tag/1.29.1) | ||
- [Docker Engine 20.10.6](https://docs.docker.com/engine/release-notes/#20106) | ||
|
||
## Bug fixes and minor changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section needs the same changes as already done in the Mac section. (Sorry, I didn't list them all twice in my first review).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully they're back in sync now!
Signed-off-by: David Scott <[email protected]>
|
||
## Removed features | ||
|
||
- Removed the "Deploy Docker Stacks to Kubernetes by default" Kubernetes setting. The component was removed in 2.4.0.0 but we forgot to remove the setting. Fixes [docker/for-mac#4966](https://github.com/docker/for-mac/issues/4966). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could put this in the bug fixes section as the functionality itself was actually removed earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Signed-off-by: David Scott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve now, but the date does still need changing if we remember.
Signed-off-by: David Scott <[email protected]>
Co-authored-by: Usha Mandya <[email protected]>
Co-authored-by: Usha Mandya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the release date, but otherwise looks good!
Signed-off-by: Stefan Scherer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed changes
New release notes for the upcoming Docker Desktop 3.3.2 release!
Marked WIP because the final binaries are not yet ready.
Unreleased project version (optional)
Related issues (optional)