-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19.03] Included named pipe mounts documentation #7427
Conversation
Deploy preview for docsdocker ready! Built with commit 3f3c585 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I found some small issues (commented inline).
So, this documentation change is for the next release (19.03), so should not be merged yet; I added [19.03]
to the title so that the documentation maintainers know it's not to be merged yet; alternatively, you can change the PR to target the vnext-engine
branch (which is a branch for upcoming releases); to do so; click the edit button;
And switch the target branch:
(I'm not sure if the vnext-engine branch is currently fully up-to-date: @ahh-docker is that branch still used by the docs team?)
e93cc37
to
ae1a46f
Compare
@thaJeztah commit is now updated but I did change base from vnext-engine back to master as it looks to be quite lot of behind. Btw. Do you know if there plan to publish 19.03 version of Docker EE? I'm just curious as that is version what is used by Windows Servers. |
@thaJeztah Sorry for the delayed response, and thank you for updating the title. I have added a new label, You are correct @olljanat - we haven't worked with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged, thank you for contributing! |
Proposed changes
Added documentation about named pipe mounts.
Related issues (optional)
This documentation was requested on docker/cli/pull/1195