-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't set cwd:// prefix for local bake files #382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
dont-set-cwd-prefix
branch
from
January 31, 2024 13:04
9f86bea
to
eda41b7
Compare
renovate bot
referenced
this pull request
in 4m-mazi/gh-test
Jan 31, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/metadata-action](https://togithub.com/docker/metadata-action) | action | patch | `v5.5.0` -> `v5.5.1` | --- ### Release Notes <details> <summary>docker/metadata-action (docker/metadata-action)</summary> ### [`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1) - Don't set `cwd://` prefix for local bake files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/382](https://togithub.com/docker/metadata-action/pull/382) **Full Changelog**: docker/metadata-action@v5.5.0...v5.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Mogyuchi/gh-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
paddatrapper
referenced
this pull request
in libretime/libretime
Feb 1, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/metadata-action](https://togithub.com/docker/metadata-action) | action | minor | `v5.4.0` -> `v5.5.1` | --- ### Release Notes <details> <summary>docker/metadata-action (docker/metadata-action)</summary> ### [`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1) - Don't set `cwd://` prefix for local bake files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/382](https://togithub.com/docker/metadata-action/pull/382) **Full Changelog**: docker/metadata-action@v5.5.0...v5.5.1 ### [`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0) - Set `cwd://` prefix for bake files path by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/370](https://togithub.com/docker/metadata-action/pull/370) - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.16.0 to 0.16.1 in [https://github.com/docker/metadata-action/pull/371](https://togithub.com/docker/metadata-action/pull/371) - Bump moment from 2.29.4 to 2.30.1 in [https://github.com/docker/metadata-action/pull/373](https://togithub.com/docker/metadata-action/pull/373) - Bump moment-timezone from 0.5.43 to 0.5.44 in [https://github.com/docker/metadata-action/pull/374](https://togithub.com/docker/metadata-action/pull/374) **Full Changelog**: docker/metadata-action@v5.4.0...v5.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/libretime/libretime). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kyle Robbertze <[email protected]>
jooola
referenced
this pull request
in mp3butcher/libretime
Feb 2, 2024
…e#2928) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/metadata-action](https://togithub.com/docker/metadata-action) | action | minor | `v5.4.0` -> `v5.5.1` | --- ### Release Notes <details> <summary>docker/metadata-action (docker/metadata-action)</summary> ### [`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1) - Don't set `cwd://` prefix for local bake files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/382](https://togithub.com/docker/metadata-action/pull/382) **Full Changelog**: docker/metadata-action@v5.5.0...v5.5.1 ### [`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0) - Set `cwd://` prefix for bake files path by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/370](https://togithub.com/docker/metadata-action/pull/370) - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.16.0 to 0.16.1 in [https://github.com/docker/metadata-action/pull/371](https://togithub.com/docker/metadata-action/pull/371) - Bump moment from 2.29.4 to 2.30.1 in [https://github.com/docker/metadata-action/pull/373](https://togithub.com/docker/metadata-action/pull/373) - Bump moment-timezone from 0.5.43 to 0.5.44 in [https://github.com/docker/metadata-action/pull/374](https://togithub.com/docker/metadata-action/pull/374) **Full Changelog**: docker/metadata-action@v5.4.0...v5.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/libretime/libretime). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kyle Robbertze <[email protected]>
This has been fixed in Buildx 0.13.0: docker/buildx#2237 |
mkolasinski-splunk
referenced
this pull request
in splunk/addonfactory-workflow-addon-release
Apr 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [apache/skywalking-eyes](https://togithub.com/apache/skywalking-eyes) | action | minor | `v0.5.0` -> `v0.6.0` | | [aws-actions/configure-aws-credentials](https://togithub.com/aws-actions/configure-aws-credentials) | | action | major | `v2` -> `v3` | | [docker/metadata-action](https://togithub.com/docker/metadata-action) | | action | minor | `v5.4.0` -> `v5.5.1` | | [pre-commit/action](https://togithub.com/pre-commit/action) | action | patch | `v3.0.0` -> `v3.0.1` | --- ### Release Notes <details> <summary>apache/skywalking-eyes (apache/skywalking-eyes)</summary> ### [`v0.6.0`](https://togithub.com/apache/skywalking-eyes/releases/tag/v0.6.0) [Compare Source](https://togithub.com/apache/skywalking-eyes/compare/v0.5.0...v0.6.0) #### What's Changed - Add `|` as comment indicator by [@​kezhenxu94](https://togithub.com/kezhenxu94) in [https://github.com/apache/skywalking-eyes/pull/168](https://togithub.com/apache/skywalking-eyes/pull/168) - Correct the way of joining slack channels by [@​wu-sheng](https://togithub.com/wu-sheng) in [https://github.com/apache/skywalking-eyes/pull/169](https://togithub.com/apache/skywalking-eyes/pull/169) - update: add weak-compatible to dependency check by [@​Two-Hearts](https://togithub.com/Two-Hearts) in [https://github.com/apache/skywalking-eyes/pull/171](https://togithub.com/apache/skywalking-eyes/pull/171) - feature: add support for Protocol Buffer by [@​spacewander](https://togithub.com/spacewander) in [https://github.com/apache/skywalking-eyes/pull/172](https://togithub.com/apache/skywalking-eyes/pull/172) - feature: add support for OPA policy files by [@​spacewander](https://togithub.com/spacewander) in [https://github.com/apache/skywalking-eyes/pull/174](https://togithub.com/apache/skywalking-eyes/pull/174) - add Eclipse Foundation specific Apache 2.0 license header by [@​gdams](https://togithub.com/gdams) in [https://github.com/apache/skywalking-eyes/pull/178](https://togithub.com/apache/skywalking-eyes/pull/178) - add instructions to fix header issues in markdown comment by [@​gdams](https://togithub.com/gdams) in [https://github.com/apache/skywalking-eyes/pull/179](https://togithub.com/apache/skywalking-eyes/pull/179) - bump action/setup-go to v5 by [@​gdams](https://togithub.com/gdams) in [https://github.com/apache/skywalking-eyes/pull/180](https://togithub.com/apache/skywalking-eyes/pull/180) - Draft release notes for 0.6.0 by [@​kezhenxu94](https://togithub.com/kezhenxu94) in [https://github.com/apache/skywalking-eyes/pull/181](https://togithub.com/apache/skywalking-eyes/pull/181) #### New Contributors - [@​Two-Hearts](https://togithub.com/Two-Hearts) made their first contribution in [https://github.com/apache/skywalking-eyes/pull/171](https://togithub.com/apache/skywalking-eyes/pull/171) - [@​gdams](https://togithub.com/gdams) made their first contribution in [https://github.com/apache/skywalking-eyes/pull/178](https://togithub.com/apache/skywalking-eyes/pull/178) **Full Changelog**: apache/skywalking-eyes@v0.5.0...v0.6.0 </details> <details> <summary>aws-actions/configure-aws-credentials (aws-actions/configure-aws-credentials)</summary> ### [`v4`](https://togithub.com/aws-actions/configure-aws-credentials/releases/tag/v4) [Compare Source](https://togithub.com/aws-actions/configure-aws-credentials/compare/v3...v4) This tag tracks the latest v4.x.x release ### [`v3`](https://togithub.com/aws-actions/configure-aws-credentials/releases/tag/v3) [Compare Source](https://togithub.com/aws-actions/configure-aws-credentials/compare/v2...v3) This tag tracks the latest v3.x.x release </details> <details> <summary>docker/metadata-action (docker/metadata-action)</summary> ### [`v5.5.1`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.1) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.5.0...v5.5.1) - Don't set `cwd://` prefix for local bake files by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/382](https://togithub.com/docker/metadata-action/pull/382) **Full Changelog**: docker/metadata-action@v5.5.0...v5.5.1 ### [`v5.5.0`](https://togithub.com/docker/metadata-action/releases/tag/v5.5.0) [Compare Source](https://togithub.com/docker/metadata-action/compare/v5.4.0...v5.5.0) - Set `cwd://` prefix for bake files path by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/metadata-action/pull/370](https://togithub.com/docker/metadata-action/pull/370) - Bump [@​docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.16.0 to 0.16.1 in [https://github.com/docker/metadata-action/pull/371](https://togithub.com/docker/metadata-action/pull/371) - Bump moment from 2.29.4 to 2.30.1 in [https://github.com/docker/metadata-action/pull/373](https://togithub.com/docker/metadata-action/pull/373) - Bump moment-timezone from 0.5.43 to 0.5.44 in [https://github.com/docker/metadata-action/pull/374](https://togithub.com/docker/metadata-action/pull/374) **Full Changelog**: docker/metadata-action@v5.4.0...v5.5.0 </details> <details> <summary>pre-commit/action (pre-commit/action)</summary> ### [`v3.0.1`](https://togithub.com/pre-commit/action/releases/tag/v3.0.1): pre-commit/[email protected] [Compare Source](https://togithub.com/pre-commit/action/compare/v3.0.0...v3.0.1) ##### Misc - [#​190](https://togithub.com/pre-commit/action/issues/190) PR by [@​SukiCZ](https://togithub.com/SukiCZ). - [#​189](https://togithub.com/pre-commit/action/issues/189) issue by [@​bakerkj](https://togithub.com/bakerkj). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/splunk/addonfactory-workflow-addon-release). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC40IiwidXBkYXRlZEluVmVyIjoiMzcuMjY5LjIiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: mkolasinski-splunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #380
fixes #381
#370 introduces a regression with Buildx 0.12.0 when merging multiple bake definitions using both
cwd://
prefix and local definitions to overrides fields. There is actually a bug in buildx that doesn't respect the order of the bake definitions passed (either through the cli with-f
or in the bake action with thefiles
input).This change removes this prefix while a fix on buildx is being worked on. I will put it back when this is fixed on buildx side and agree on Git context behavior with the bake action in docker/bake-action#181, which "requires"
cwd://
but not necessary in the current state.