-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding helpers for semver usage #385
base: master
Are you sure you want to change the base?
Conversation
c33d7d6
to
9ee6203
Compare
Signed-off-by: Mehdi Benadel <[email protected]>
9ee6203
to
17558ba
Compare
Seems like we might be having an issue here in terms of semver compliance of docker tags :
https://docs.docker.com/engine/reference/commandline/image_tag/ |
Ah completely forgot about this limitation 😞 |
Ok, so until we get any news from those, we can use this but with a hyphen instead of a plus ? kinda breaks readability of semver but what can we do ? Use another letter/keyword ? An underscore maybe ? docker/cli#4877 |
Don't think we have much choice atm than waiting. Hyphens are specially treated by semver spec to handle prerelease. That would break versioning. Feel free to put this PR in draft or close it in the meantime but we can keep the issue opened for tracking. |
Attempt to fix #384
I kinda fail at getting why IsRawStatement exists, and also why {{major}}.{{minor}} (in tag13 test) is supposed to give {{version}} ?
Hopefully this works properly and helps users get the best from the tags.