Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase short commit hash length to 12 for uniqueness #467

Merged
merged 3 commits into from
Oct 31, 2024
Merged

increase short commit hash length to 12 for uniqueness #467

merged 3 commits into from
Oct 31, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 31, 2024 •
edited
Loading

fixes #453

Also adds DOCKER_METADATA_SHORT_SHA_LENGTH env var to customize short commit SHA length.

cc @rumpl @dvdksn

@crazy-max crazy-max force-pushed the increase-short-sha-size branch 2 times, most recently from 164502b to d965fc6 Compare October 31, 2024 09:43
@crazy-max crazy-max marked this pull request as ready for review October 31, 2024 09:44
rumpl
rumpl approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@crazy-max crazy-max merged commit 9b90a2e into docker:master Oct 31, 2024
32 checks passed
@crazy-max crazy-max deleted the increase-short-sha-size branch October 31, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdksn dvdksn dvdksn approved these changes

@rumpl rumpl rumpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag's sha hash is not long enough in the hash collision case
3 participants
@crazy-max @rumpl @dvdksn