-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEAB-6452: fix null error #496
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #496 +/- ##
==========================================
Coverage 45.13% 45.13%
Complexity 305 305
==========================================
Files 47 47
Lines 2663 2663
Branches 205 205
==========================================
Hits 1202 1202
Misses 1368 1368
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
githubdelivery/src/main/java/io/dockstore/githubdelivery/GithubDeliveryS3Client.java
Outdated
Show resolved
Hide resolved
githubdelivery/src/main/java/io/dockstore/githubdelivery/GithubDeliveryS3Client.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was here, going to wait for response to other feedback first; please re-request review then.
githubdelivery/src/main/java/io/dockstore/githubdelivery/GithubDeliveryS3Client.java
Outdated
Show resolved
Hide resolved
githubdelivery/src/main/java/io/dockstore/githubdelivery/GithubDeliveryS3Client.java
Outdated
Show resolved
Hide resolved
githubdelivery/src/main/java/io/dockstore/githubdelivery/GithubDeliveryS3Client.java
Outdated
Show resolved
Hide resolved
githubdelivery/src/main/java/io/dockstore/githubdelivery/GithubDeliveryS3Client.java
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
Description
This PR fixes the null error found during sprint demo.
Review Instructions
Same as #492
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6452
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)