Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legal UTF-8 method names #69

Closed
mperham opened this issue Oct 31, 2013 · 5 comments
Closed

Handle legal UTF-8 method names #69

mperham opened this issue Oct 31, 2013 · 5 comments

Comments

@mperham
Copy link

mperham commented Oct 31, 2013

RubyDoc.info currently blows up with UTF-8 method names, like:

https://github.com/mperham/sidekiq/blob/master/lib/sidekiq.rb#L25

which leads to this:

http://rubydoc.info/gems/sidekiq/Sidekiq

@lsegal
Copy link
Collaborator

lsegal commented Oct 31, 2013

Looks like our filename serializer regex doesn't like unicode. Should be easy enough to fix but I will have to look at it.

@lsegal
Copy link
Collaborator

lsegal commented Nov 1, 2013

Interestingly it's not our code that doesn't like this, it's Webrick's escape() function that doesn't handle unicode, which is pretty interesting, since we use that quite a bit.

@mperham
Copy link
Author

mperham commented Nov 1, 2013

Not sure if this is the same thing but I recently switched to Rack::Utils
for html escaping.

sidekiq/sidekiq@2243426

On Fri, Nov 1, 2013 at 2:55 PM, Loren Segal [email protected]:

Interestingly it's not our code that doesn't like this, it's Webrick's
escape() function that doesn't handle unicode, which is pretty interesting,
since we use that quite a bit.


Reply to this email directly or view it on GitHubhttps://github.com//issues/69#issuecomment-27604199
.

@lsegal
Copy link
Collaborator

lsegal commented Nov 2, 2013

Seems to be fixed by the above commit. Will be deploying now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants