Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar active class and expand don't work as expect when use "space" in markdown filename #1032

Closed
1 task done
csu-feizao opened this issue Feb 23, 2020 · 5 comments · Fixed by #1454, nearform/mira-sample-s3-webhosting#19, moneytree/mt-link-javascript-sdk#69 or Buzut/jamments#17 · May be fixed by 2A5F/OneDark-Pro#2
Labels

Comments

@csu-feizao
Copy link

Bug Report

Steps to reproduce

  1. create an markdown file and use test sidebar.md as it's name
  2. make sure this markdown file has some content so that can generate some item in sidebar
  3. open the url /#/test%20sidebar
  4. click the sidebar item, and you will see sometimes the item doesn't has active class
  5. create more markdown file, and set loadSidebar to use custom sidebar
  6. config subMaxLevel
  7. click the sidebar item, and you will find out that the sidebar item can't be expanded

What is current behaviour

  1. sidebar item doesn't has active class when click
  2. sidebar item doesn't been expanded when click

What is the expected behaviour

  1. sidebar item has active class when click
  2. sidebar item will be expanded when click
  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Mac OS 10.13.6 (17G65)

  • Node.js version: N/A

  • npm/yarn version: N/A (use index.html)

  • Browser version: Chrome 79.0.3945.130

  • Docsify version: unpkg latest

  • Docsify plugins: N/A

@anikethsaha
Copy link
Member

anikethsaha commented Feb 23, 2020

Can you share a reproducible repo? having a repo makes things quicker 👍

create an markdown file and use test sidebar.md as it's name

Just a note that it is never recommended to use a space in a markdown file name. Use - instead of space.

@csu-feizao
Copy link
Author

Can you share a reproducible repo? having a repo makes things quicker 👍

create an markdown file and use test sidebar.md as it's name

Just a note that it is never recommended to use a space in a markdown file name. Use - instead of space.

hi, this is the repo, sorry for reply so late

@anikethsaha
Copy link
Member

Thanks I will take a look .
Feel free to investigate and submit a fix if its a bug to make the process faster. cause I think i cant investigate it any time soon.

@csu-feizao csu-feizao mentioned this issue Mar 3, 2020
19 tasks
@anikethsaha
Copy link
Member

as per the repo you shared, I could get the hightlighted sidebar links for activeBug page
and I can confirm with the expand bug , its a bug

@enzy
Copy link
Contributor

enzy commented Dec 17, 2020

PR provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment