fix: sidebar active class and expand don't work as expect when use "space" in markdown filename #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/lmdo37xnk |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 92c6810:
|
trusktr
previously approved these changes
Dec 17, 2020
|
Thanks for this! I think this looks good. |
|
|
sy-records
changed the title
sy-records
changed the title
sy-records
approved these changes
Dec 18, 2020
Koooooo-7
approved these changes
Dec 18, 2020
trusktr
reviewed
Dec 20, 2020
|
|
||
| await page.click('a[href="#/test"]'); | ||
| await expect(page).toEqualText('.sidebar-nav li[class=active]', 'Test'); | ||
| expect(page.url()).toMatch(/\/test$/); |
There was a problem hiding this comment.
Nice! I get a good warm feeling of Docsify stability improving now!
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes URL decoding problem in sidebar, reported in #1032. It builds on previous work in #1043, but with rebased and updated fix (just 1 line now).
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)fix sidebar active class and expand don't work as expect when use "space" in markdown filename #1032, close fix #1032 #1043
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.