We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docsify assumes the logo option value is an absolute path. This prevents the use of several valid image src values.
logo
src
Example:
logo: "logo.svg"
Output:
<img alt="docsify-themeable" src="/logo.svg">
Notice the auto-inserted forward slash at the beginning of the src attribute. This behavior prevents valid image sources from being used:
Base64:
logo: "data:image/png;base64, ..."
<img alt="docsify-themeable" src="/data:image/png;base64, ...">
Relative path:
logo: "../logo.svg"
<img alt="docsify-themeable" src="/../logo.svg">
External URL:
logo: "https://docsify.js.org/_media/icon.svg"
<img alt="docsify-themeable" src="/https://docsify.js.org/_media/icon.svg">
The fix seems straightforward: just use the logo option value as-is for the image src.
Thanks!
The text was updated successfully, but these errors were encountered:
feat: Allow base64, external, and relative logo values (#642)
0a0802a
Fix #577
No branches or pull requests
Docsify assumes the
logo
option value is an absolute path. This prevents the use of several valid imagesrc
values.Example:
logo: "logo.svg"
Output:
Notice the auto-inserted forward slash at the beginning of the
src
attribute. This behavior prevents valid image sources from being used:Base64:
Relative path:
External URL:
The fix seems straightforward: just use the
logo
option value as-is for the imagesrc
.Thanks!
The text was updated successfully, but these errors were encountered: